PLEX-2149 fix add capabilities CLD to prevent removal of existing cabilities in the DON #20530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abilities in the DON
product-security-plaid-production
bot
requested review from
ettec and
jkongie
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements capability configuration merging to prevent accidental removal of existing capabilities when adding new ones to a DON (Decentralized Oracle Network). The core change introduces a merge mechanism that preserves existing capabilities on-chain when new capabilities are added.
- Adds a
MergeCapabilityConfigsWithOnChainflag to control whether new capabilities should be merged with existing ones - Refactors capability configuration logic to use a map-based approach with deduplication
- Extends test coverage to verify that adding multiple capabilities sequentially preserves all configurations
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
deployment/cre/capabilities_registry/v2/changeset/sequences/add_capabilities.go |
Sets merge flag to true when updating DON capabilities |
deployment/cre/capabilities_registry/v2/changeset/operations/contracts/update_don.go |
Implements capability merging logic with map-based deduplication and sorting |
deployment/cre/capabilities_registry/v2/changeset/add_capabilities_test.go |
Adds test to verify sequential capability additions preserve existing configurations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
deployment/cre/capabilities_registry/v2/changeset/add_capabilities_test.go
Outdated
Show resolved
Hide resolved
vyzaldysanchez
previously approved these changes
Dec 5, 2025
…ties_test.go Co-authored-by: Copilot <[email protected]>
|
yashnevatia
approved these changes
Dec 8, 2025
DylanTinianov
approved these changes
Dec 8, 2025
vyzaldysanchez
approved these changes
Dec 8, 2025
dhaidashenko
changed the title
krehermann
pushed a commit
that referenced
this pull request
Dec 11, 2025
…ilities in the DON (#20530) * PLEX-2149 fix add capabilities CLD to prevent removal of existing capabilities in the DON * Update deployment/cre/capabilities_registry/v2/changeset/add_capabilities_test.go Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> (cherry picked from commit 1e6d72f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.